Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(eslint-config): Fix the repository url #365

Merged
merged 1 commit into from
Feb 12, 2025
Merged

fix(eslint-config): Fix the repository url #365

merged 1 commit into from
Feb 12, 2025
+33 −10

Conversation

wakamsha
Copy link
Contributor

What changed / motivation ?

Due to the repository name change and the move of eslint-config-moneyforward to a workspace under the monorepo, all hard-coded URLs must be revised.

There are no changes to the eslint-config-moneyforward codebase, but the URL listed in the npm registry needs to be updated, so this fix will be released as a patch update.

スクリーンショット 2025-02-10 15 02 30

Linked PR / Issues

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update
  • Chore (routine task, maintenance, or non-functional change that doesn't modify src or test files)

Pre-flight checklist

References

@wakamsha
fix(eslint-config): Fix the repository url
f776bcd 
fix(eslint-config): Fix the repository url

fix(eslint-config): Fix the repository url
@wakamsha wakamsha self-assigned this Feb 10, 2025
tongari07
tongari07 approved these changes Feb 12, 2025
View reviewed changes
Copy link
Contributor

@tongari07 tongari07 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! LGTM 👍

@wakamsha wakamsha merged commit 87beb0c into main Feb 12, 2025
2 checks passed
@wakamsha wakamsha deleted the fix/repository-url branch February 12, 2025 09:54
oss-frontend-github-app bot pushed a commit that referenced this pull request Feb 13, 2025
@semantic-release-bot
chore(release): 5.1.0 [skip ci]
ef0045d 
## [eslint-config-moneyforward-v5.1.0](5.0.2...5.1.0) (2025-02-13)

### Features

* **eslint-config:** Update `typescript-eslint` deps ([#366](#366)) ([719d2da](719d2da))

### Bug Fixes

* **eslint-config:** Fix the repository url ([#365](#365)) ([87beb0c](87beb0c))
@oss-frontend-github-app
Copy link

🎉 This PR is included in version eslint-config-moneyforward-v5.1.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tongari07 tongari07 tongari07 approved these changes

@keroken keroken Awaiting requested review from keroken

@taigakiyokawa taigakiyokawa Awaiting requested review from taigakiyokawa

Assignees

@wakamsha wakamsha

Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wakamsha @tongari07